feat: add specs generator & fix body params #49

didavila · 2026-03-26T10:21:59Z

didavila commented

2026-03-26 10:21:59 +00:00

Resolves: #36

didavila added the enhancement label 2026-03-26 10:21:59 +00:00

didavila self-assigned this 2026-03-26 10:21:59 +00:00

didavila added 2 commits 2026-03-26 10:22:03 +00:00

feat: add .spec.ts generation for models, mappers, repositories and use-cases 463626da0c

Add 4 new Mustache templates for generating unit test specs:
- model-entity.spec.mustache: tests instantiation, property setting, mock builder
- mapper.spec.mustache: tests per-property DTO→Entity mapping, instanceof, all fields
- api.repository.impl.spec.mustache: tests HTTP method, response mapping, error propagation
- api.use-cases.impl.spec.mustache: tests repository delegation, observable forwarding

Generator changes:
- Add uppercaseHttpMethod to TagOperation for spec HTTP assertions
- Add testValue to TagOperationParam for auto-generated test arguments
- Add resolveTestParamValue utility for primitive/complex type test literals
- Add specs counter to GeneratedCount and GenerationReport
- Wire 4 new renderTemplate calls in schema and tag loops
- Update report generator to count .spec.ts files

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: body param and 2xx response codes in repository generation

Lint / lint (pull_request) Successful in 31s

Details

d47afb6ff1

Bug 1 - Body as positional argument (api.repository.impl.mustache):
MRepository HTTP methods accept a single RequestOptions object as second
argument. The template was incorrectly passing body as a separate positional
argument (e.g. this.post('/url', body)), causing:
  'Type X has no properties in common with type RequestOptions'
Fix: merge body into the options object using ES6 shorthand { body }, and
introduce hasOptions / hasBothParamsAndBody flags to build a single unified
options literal covering all scenarios:
  - no options    → this.post('/url')
  - params only   → this.get('/url', { params: { search } })
  - body only     → this.post('/url', { body })
  - params + body → this.post('/url', { params: { search }, body })

Bug 2 - Only 200 responses read (clean-arch.generator.ts):
The generator was hardcoded to read op.responses['200'], silently ignoring
201 Created, 202 Accepted, etc. POST endpoints returning 201 were generated
as Observable<void> instead of their actual return type.
Fix: resolve the first available success code from [200, 201, 202, 203].

New fields added to TagOperation type:
  - uppercaseHttpMethod: string
  - hasOptions: boolean
  - hasBothParamsAndBody: boolean

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

didavila requested review from blas 2026-03-26 10:22:04 +00:00

blas approved these changes 2026-03-26 10:33:03 +00:00

blas merged commit 5707abf6bb into main

2026-03-26 10:33:08 +00:00

blas referenced this issue from a commit

2026-03-26 10:33:10 +00:00

Merge pull request 'feat: add specs generator & fix body params' (#49) from feat/add-specs into main

blas deleted branch feat/add-specs

2026-03-26 10:33:14 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blas/openapi-clean-arch-gen#49