blas/openapi-clean-arch-gen
1
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects 1 Releases 6 Wiki Activity

fix: fix template variable wrapping to fit java requirements #14

Merged
blas merged 2 commits from fix/review-templates into main 2026-03-23 15:46:31 +00:00
Conversation 0 Commits 2 Files Changed 8 +32 -20
didavila commented 2026-03-23 15:32:08 +00:00
Collaborator
Copy Link

🛠️ Refactor: Template Type Safety & Provider Modernization

Description

This PR addresses type compatibility issues between our templates and the Java backend while modernizing how we handle dependency injection.

Key Changes

  • Java Compatibility Fixes: Refactored templates to prevent type mismatches and "breaking" builds when interacting with Java-based data structures.
  • Modernized DI Patterns: Rewrote provider templates to utilize the makeEnvironmentProviders API, aligning with current Angular best practices for more efficient tree-shaking and cleaner configuration.

Impact

  • Improved type safety across the board.
  • Standardized provider definitions.
  • Reduced risk of runtime errors due to backend/frontend type friction.

resolves #2

## 🛠️ Refactor: Template Type Safety & Provider Modernization ### Description This PR addresses type compatibility issues between our templates and the Java backend while modernizing how we handle dependency injection. ### Key Changes * **Java Compatibility Fixes:** Refactored templates to prevent type mismatches and "breaking" builds when interacting with Java-based data structures. * **Modernized DI Patterns:** Rewrote provider templates to utilize the `makeEnvironmentProviders` API, aligning with current Angular best practices for more efficient tree-shaking and cleaner configuration. ### Impact - Improved type safety across the board. - Standardized provider definitions. - Reduced risk of runtime errors due to backend/frontend type friction. resolves #2
didavila added the bug label 2026-03-23 15:32:08 +00:00
didavila self-assigned this 2026-03-23 15:32:08 +00:00
didavila added 2 commits 2026-03-23 15:32:11 +00:00
fix: fix template variable wrapping to fit java requirements 4905f84d2c
fix: refactor providers to use makeEnvironmentProviders 9805a14111
didavila requested review from blas 2026-03-23 15:32:11 +00:00
didavila added this to the Generador project 2026-03-23 15:32:13 +00:00
didavila changed title from fix/review-templates to fix: review-templates 2026-03-23 15:45:41 +00:00
blas changed title from fix: review-templates to fix: fix template variable wrapping to fit java requirements 2026-03-23 15:46:07 +00:00
blas merged commit 7c971a8409 into main 2026-03-23 15:46:31 +00:00
didavila moved this to In Progress in Generador on 2026-03-24 07:30:53 +00:00
didavila moved this to Done in Generador on 2026-03-24 07:30:55 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
blas
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project Generador
Assignees
Clear assignees
actions didavila blas
No Assignees didavila
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blas/openapi-clean-arch-gen#14
Delete Branch "fix/review-templates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?